Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C-005 Cleanup (Reorder perms and classes) #783

Closed
wants to merge 1 commit into from
Closed

C-005 Cleanup (Reorder perms and classes) #783

wants to merge 1 commit into from

Conversation

freedom1b2830
Copy link
Contributor

I decided to start clearing the warnings, even though they are not significant

Signed-off-by: freedom1b2830 [email protected]

@freedom1b2830
Reorder perms and classes
1e4b689 
Signed-off-by: freedom1b2830 <[email protected]>
@pebenito
Copy link
Member

Did you use sediff to verify there were no changes in the final policy?

@freedom1b2830
Copy link
Contributor Author

I didn't know about checking with sediff.
launched it with old and new policy.33, no output.
What arguments should I run sediff with?

@pebenito
Copy link
Member

I didn't know about checking with sediff. launched it with old and new policy.33, no output. What arguments should I run sediff with?

No output means there are no changes.

@pebenito
Copy link
Member

pebenito commented Jun 27, 2024 •
edited
Loading

It took some time, but I manually reviewed all the changes and it look good.

I've added sediff to the GitHub checks; would you please rebase your change to main so it will run the new checks? I'd like extra confirmation there are no permission changes since the checks run in multiple combinations of the build options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freedom1b2830 @pebenito